Skip to content

feat: add ml/base/kmeans/metric-enum2str#10841

Merged
kgryte merged 5 commits into
stdlib-js:developfrom
nakul-krishnakumar:kmeans-metric-enum2str
May 27, 2026
Merged

feat: add ml/base/kmeans/metric-enum2str#10841
kgryte merged 5 commits into
stdlib-js:developfrom
nakul-krishnakumar:kmeans-metric-enum2str

Conversation

@nakul-krishnakumar
Copy link
Copy Markdown
Member

@nakul-krishnakumar nakul-krishnakumar commented Mar 9, 2026 •
edited by kgryte
Loading

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Adds ml/base/kmeans/metric-enum2str.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 9, 2026
@nakul-krishnakumar
Copy link
Copy Markdown
Member Author

nakul-krishnakumar commented Mar 9, 2026 •
edited
Loading

This PR is blocked by #10714 and in cyclic dependency with #10842

nakul-krishnakumar
nakul-krishnakumar commented Mar 9, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/ml/base/cluster/kmeans/metric-enum2str/docs/repl.txt Outdated
@nakul-krishnakumar
style: update according to code review
683a7e6 
Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>
@nakul-krishnakumar nakul-krishnakumar changed the title feat: add ml/base/cluster/kmeans/metric-enum2str feat: add ml/base/cluster/kmeans/metric-(enum2str|str2enum) Mar 9, 2026
@nakul-krishnakumar nakul-krishnakumar changed the title feat: add ml/base/cluster/kmeans/metric-(enum2str|str2enum) feat: add ml/base/cluster/kmeans/metric-enum2str Mar 9, 2026
@nakul-krishnakumar nakul-krishnakumar mentioned this pull request Mar 9, 2026
Merged
7 tasks
This was referenced Mar 27, 2026
Open
Closed
@kgryte kgryte requested a review from a team May 27, 2026 08:37
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 27, 2026

@nakul-krishnakumar Looks like you'll want to move this package.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Machine Learning Issue or pull request specific to machine learning functionality. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 27, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 27, 2026
@nakul-krishnakumar
Copy link
Copy Markdown
Member Author

nakul-krishnakumar commented May 27, 2026

@kgryte I still had some changes to make here

@nakul-krishnakumar
Copy link
Copy Markdown
Member Author

nakul-krishnakumar commented May 27, 2026

@nakul-krishnakumar Looks like you'll want to move this package.

Yes, I will do that.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 27, 2026
@kgryte kgryte changed the title feat: add ml/base/cluster/kmeans/metric-enum2str feat: add ml/base/kmeans/metric-enum2str May 27, 2026
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label May 27, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 27, 2026

As the CI failure is expected, I'll go ahead and merge.

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 27, 2026

Coverage Report

Package Statements Branches Functions Lines
ml/base/kmeans/metric-enum2str $\color{green}104/104$
$\color{green}+100.00%$ 		$\color{green}5/5$
$\color{green}+100.00%$ 		$\color{green}1/1$
$\color{green}+100.00%$ 		$\color{green}104/104$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte merged commit cb7ba1d into stdlib-js:develop May 27, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Machine Learning Issue or pull request specific to machine learning functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nakul-krishnakumar @kgryte @stdlib-bot